[webkit-reviews] review granted: [Bug 178052] Update Document.createEvent for recent DOM specification changes : [Attachment 323102] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 7 16:38:03 PDT 2017


Chris Dumez <cdumez at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 178052: Update Document.createEvent for recent DOM specification changes
https://bugs.webkit.org/show_bug.cgi?id=178052

Attachment 323102: Patch

https://bugs.webkit.org/attachment.cgi?id=323102&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 323102
  --> https://bugs.webkit.org/attachment.cgi?id=323102
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323102&action=review

I had not touched this area because last time I checked, browsers disagreed
with the specification and behaved widely differently. Also, the spec did not
make sense in some cases. However, the changes here make sense. r=me

> Source/WebCore/dom/Document.cpp:4273
> +    if (equalLettersIgnoringASCIICase(type, "beforeunloadevent"))

I have confirmed that beforeunloadevent is supported by both Firefox and
Chrome.

> Source/WebCore/dom/Document.cpp:4279
> +    if (equalLettersIgnoringASCIICase(type, "event") ||
equalLettersIgnoringASCIICase(type, "events") ||
equalLettersIgnoringASCIICase(type, "htmlevents") ||
equalLettersIgnoringASCIICase(type, "svgevents"))

I have confirmed that svgevents is supported by both Firefox and Chrome.

> Source/WebCore/dom/Document.cpp:4281
> +    if (equalLettersIgnoringASCIICase(type, "focusevent"))

I have confirmed that focus event is supported by both Firefox and Chrome.

> Source/WebCore/dom/Document.cpp:4329
> +    if (equalLettersIgnoringASCIICase(type, "keyboardevents"))

Looks like Chrome dropped it already, Firefox did not.

> Source/WebCore/dom/Document.cpp:4335
> +    if (equalLettersIgnoringASCIICase(type, "popstateevent"))

Looks like Firefox dropped it already, Chrome did not.


More information about the webkit-reviews mailing list