[webkit-reviews] review granted: [Bug 177430] Tools/Scripts/run-jsc --debugger no longer works in recent versions of Mac OS : [Attachment 322828] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 6 23:25:20 PDT 2017


Alexey Proskuryakov <ap at webkit.org> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 177430: Tools/Scripts/run-jsc --debugger no longer works in recent versions
of Mac OS
https://bugs.webkit.org/show_bug.cgi?id=177430

Attachment 322828: Patch

https://bugs.webkit.org/attachment.cgi?id=322828&action=review




--- Comment #10 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 322828
  --> https://bugs.webkit.org/attachment.cgi?id=322828
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322828&action=review

> Tools/ChangeLog:8
> +	   The problem is caused by System Integrity Protection on recent
versions of Mac OS: it removes some environment variables, including
DYLD_FRAMEWORK_PATH before running lldb.

"(see <rdar://problem/21732670>)"

> Tools/Scripts/run-jsc:50
> +my $productDir = jscProductDir();

WebKit coding style strongly prefers avoiding abbreviations, so regardless of
how the function is called, I recommend fully spelling out the variable name.

> Tools/Scripts/run-jsc:57
> +	   $jsc = "lldb -O \"env DYLD_FRAMEWORK_PATH=" . $productDir . "\" " .
File::Spec->catfile(jscProductDir(), "jsc -- ") . "@ARGV";

This needs quotes or escaping in case $productDir path has anything interesting
in it (such as quote marks or spaces).


More information about the webkit-reviews mailing list