[webkit-reviews] review granted: [Bug 178005] [Readable Streams API] Implement canCloseOrEnqueue : [Attachment 323011] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 6 08:33:02 PDT 2017
youenn fablet <youennf at gmail.com> has granted Romain Bellessort
<romain.wkt at gmail.com>'s request for review:
Bug 178005: [Readable Streams API] Implement canCloseOrEnqueue
https://bugs.webkit.org/show_bug.cgi?id=178005
Attachment 323011: Patch
https://bugs.webkit.org/attachment.cgi?id=323011&action=review
--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 323011
--> https://bugs.webkit.org/attachment.cgi?id=323011
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323011&action=review
This sound ok to me.
We loose some precision in the exception messages but I guess this is ok.
> Source/WebCore/Modules/streams/ReadableStreamInternals.js:547
> + return false;
Maybe we can write this as a one liner?
More information about the webkit-reviews
mailing list