[webkit-reviews] review granted: [Bug 177995] Add try-bot button on perf analysis status page. : [Attachment 322991] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 6 00:26:33 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 177995: Add try-bot button on perf analysis status page.
https://bugs.webkit.org/show_bug.cgi?id=177995

Attachment 322991: Patch

https://bugs.webkit.org/attachment.cgi?id=322991&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 322991
  --> https://bugs.webkit.org/attachment.cgi?id=322991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322991&action=review

> Websites/perf.webkit.org/public/v3/pages/analysis-category-toolbar.js:74
> +	       .trybot-toolbar {

Rename this to .create-button

> Websites/perf.webkit.org/public/v3/pages/analysis-category-toolbar.js:85
> +		   <li><a href="#/analysis/task/create">TryBot</a></li>

Let's label this as "Create" instead.


More information about the webkit-reviews mailing list