[webkit-reviews] review granted: [Bug 177947] [Cairo] Create Cairo patterns from Gradient objects on-the-fly : [Attachment 322843] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 6 00:09:28 PDT 2017
Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 177947: [Cairo] Create Cairo patterns from Gradient objects on-the-fly
https://bugs.webkit.org/show_bug.cgi?id=177947
Attachment 322843: Patch
https://bugs.webkit.org/attachment.cgi?id=322843&action=review
--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 322843
--> https://bugs.webkit.org/attachment.cgi?id=322843
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=322843&action=review
> Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:82
> - cairo_t* cr = context->platformContext()->cr();
> + RefPtr<cairo_pattern_t> gradient(adoptRef(createPlatformGradient(1.0)));
We normally use = with adoptRef().
> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:276
> + RefPtr<cairo_pattern_t>
cairoPattern(adoptRef(gradient->createPlatformGradient(globalAlpha)));
Ditto.
More information about the webkit-reviews
mailing list