[webkit-reviews] review requested: [Bug 177989] Web Inspector: Improve setting the default / initial sort of a Table : [Attachment 322980] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 5 20:30:31 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 177989: Web Inspector: Improve setting the default / initial sort of a
Table
https://bugs.webkit.org/show_bug.cgi?id=177989

Attachment 322980: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=322980&action=review




--- Comment #1 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 322980

  --> https://bugs.webkit.org/attachment.cgi?id=322980&action=review

[PATCH] Proposed Fix

I like this approach for setting up the default sort. Its easy to find and not
too invasive in code. It probably depends on ordering (ensure columns are added
before setting the default sort) but thats a pattern I'm already following and
encouraging.


More information about the webkit-reviews mailing list