[webkit-reviews] review granted: [Bug 175383] Add "display" to FontFace Javascript object : [Attachment 322930] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 5 17:57:43 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 175383: Add "display" to FontFace Javascript object
https://bugs.webkit.org/show_bug.cgi?id=175383

Attachment 322930: Patch

https://bugs.webkit.org/attachment.cgi?id=322930&action=review




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 322930
  --> https://bugs.webkit.org/attachment.cgi?id=322930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322930&action=review

> LayoutTests/fast/text/font-loading-font-display.html:21
> +let values = ["auto", "block", "swap", "fallback", "optional"];

Maybe test setting to an invalid value?


More information about the webkit-reviews mailing list