[webkit-reviews] review granted: [Bug 174165] DataTransfer shouldn't contain text/html when performing Paste and Match Style : [Attachment 322794] Fixes builds
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 5 15:21:30 PDT 2017
Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 174165: DataTransfer shouldn't contain text/html when performing Paste and
Match Style
https://bugs.webkit.org/show_bug.cgi?id=174165
Attachment 322794: Fixes builds
https://bugs.webkit.org/attachment.cgi?id=322794&action=review
--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 322794
--> https://bugs.webkit.org/attachment.cgi?id=322794
Fixes builds
View in context: https://bugs.webkit.org/attachment.cgi?id=322794&action=review
r=me; let's figure out why it's failing EWS.
>
LayoutTests/editing/pasteboard/data-transfer-get-data-on-paste-as-plain-text-wh
en-custom-pasteboard-data-disabled.html:11
> +description('Tests that pasting as plain text only exposes "text/plain" in
the clipboard.');
It doesn't seem like this description is consistent with the test expectations
below.
>
LayoutTests/editing/pasteboard/data-transfer-get-data-on-paste-as-plain-text-wh
en-custom-pasteboard-data-disabled.html:13
> +if (!window.internals || !window.internals.settings) {
No braces for single line if statement.
More information about the webkit-reviews
mailing list