[webkit-reviews] review granted: [Bug 177968] RenderListItem should not hold raw pointers to RenderListMarker. : [Attachment 322917] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 5 14:57:07 PDT 2017


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 177968: RenderListItem should not hold raw pointers to RenderListMarker.
https://bugs.webkit.org/show_bug.cgi?id=177968

Attachment 322917: Patch

https://bugs.webkit.org/attachment.cgi?id=322917&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 322917
  --> https://bugs.webkit.org/attachment.cgi?id=322917
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322917&action=review

> Source/WebCore/rendering/RenderListItem.cpp:332
> +	   RenderBox* renderBox = m_marker.get();

Would this have a more descriptive name? 'markerAncestor' or something?


More information about the webkit-reviews mailing list