[webkit-reviews] review granted: [Bug 177960] RenderButton should not hold raw pointers to its direct children. : [Attachment 322888] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 5 13:10:00 PDT 2017
Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 177960: RenderButton should not hold raw pointers to its direct children.
https://bugs.webkit.org/show_bug.cgi?id=177960
Attachment 322888: Patch
https://bugs.webkit.org/attachment.cgi?id=322888&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 322888
--> https://bugs.webkit.org/attachment.cgi?id=322888
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=322888&action=review
> Source/WebCore/rendering/RenderButton.cpp:83
> // violated.
> if (&oldChild == m_inner || !m_inner || oldChild.parent() == this) {
> ASSERT(&oldChild == m_inner || !m_inner);
The comment above talks about "security problems" that I don't think exist with
the recent improvements. Maybe the comment, oldChild.parent() == this test and
the assert can go?
More information about the webkit-reviews
mailing list