[webkit-reviews] review granted: [Bug 177953] RenderSVGRoot should check the renderers inside its visualOverflowRect for hit testing if the overflow is visible : [Attachment 322871] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 5 13:03:14 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 177953: RenderSVGRoot should check the renderers inside its
visualOverflowRect for hit testing if the overflow is visible
https://bugs.webkit.org/show_bug.cgi?id=177953

Attachment 322871: Patch

https://bugs.webkit.org/attachment.cgi?id=322871&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 322871
  --> https://bugs.webkit.org/attachment.cgi?id=322871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322871&action=review

> Source/WebCore/ChangeLog:5
> +	   https://bugs.webkit.org/show_bug.cgi?id=177953
> +

Should be a link to the radar here.

> Source/WebCore/ChangeLog:13
> +	   If an SVGElement is positioned outside the rectangle of the root
element,
> +	   it can still be drawn if the root element has "overflow: visible"
applied.
> +	   But since SVGElement can be drawn in this case, it should be
accessible
> +	   through nodeAtPoint() which is used for hit testing.

Does this do the right thing if another HTML element overlaps the visual
overflow and has higher z-index?


More information about the webkit-reviews mailing list