[webkit-reviews] review granted: [Bug 177930] Layout Test media/modern-media-controls/scrubber-support/scrubber-support-click.html is flaky : [Attachment 322819] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 177930: Layout Test
media/modern-media-controls/scrubber-support/scrubber-support-click.html is
flaky
https://bugs.webkit.org/show_bug.cgi?id=177930

Attachment 322819: Patch

https://bugs.webkit.org/attachment.cgi?id=322819&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 322819
  --> https://bugs.webkit.org/attachment.cgi?id=322819
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322819&action=review

> LayoutTests/ChangeLog:10
> +	   In cases where this test failed, it actually worked as expected but
the "timeupdate" event would be fired
> +	   twice, most likely because it was registered twice. We now use an
asynchronous expectation to run the test
> +	   which should only register the event listener once and make the test
more reliable.

You could probably just pass in a { once: true } to the event listener
registration. Or are you saying it was actually registered twice?