[webkit-reviews] review granted: [Bug 177933] Make the names of the options consistent : [Attachment 322833] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 5 09:06:43 PDT 2017


Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 177933: Make the names of the options consistent
https://bugs.webkit.org/show_bug.cgi?id=177933

Attachment 322833: Patch

https://bugs.webkit.org/attachment.cgi?id=322833&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 322833
  --> https://bugs.webkit.org/attachment.cgi?id=322833
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322833&action=review

r=me with comments and when you fix the build

> Source/JavaScriptCore/ChangeLog:3
> +	   Rename verboseDFGByteCodeParsing in verboseDFGBytecodeParsing

This should be the bugzilla bug name

The prepare ChangeLog script takes a “-b” option that’ll fill this out for you

> Source/WebCore/ChangeLog:3
> +	   Fix typos in comments

This should be the bugzilla name


More information about the webkit-reviews mailing list