[webkit-reviews] review granted: [Bug 177944] Avoid integer overflow in DFGStrengthReduction.cpp : [Attachment 322838] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 5 08:58:36 PDT 2017


Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 177944: Avoid integer overflow in DFGStrengthReduction.cpp
https://bugs.webkit.org/show_bug.cgi?id=177944

Attachment 322838: Patch

https://bugs.webkit.org/attachment.cgi?id=322838&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 322838
  --> https://bugs.webkit.org/attachment.cgi?id=322838
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322838&action=review

> Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:158
> +		   if (value != INT32_MIN) {

Why not use Checked here?


More information about the webkit-reviews mailing list