[webkit-reviews] review granted: [Bug 177897] check-webkit-style erroneously requires a space between the caret and brace in obj-c blocks. : [Attachment 322739] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 4 23:52:31 PDT 2017


Daniel Bates <dbates at webkit.org> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 177897: check-webkit-style erroneously requires a space between the caret
and brace in obj-c blocks.
https://bugs.webkit.org/show_bug.cgi?id=177897

Attachment 322739: Patch

https://bugs.webkit.org/attachment.cgi?id=322739&action=review




--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 322739
  --> https://bugs.webkit.org/attachment.cgi?id=322739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322739&action=review

> Tools/ChangeLog:3
> +	   check-webkit-style erroneously requires a space between the carrot
and brace in obj-c blocks.

Blocks are not specific to Objective-C.

https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Prog
rammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html

> Tools/Scripts/webkitpy/style/checkers/cpp.py:1265
> +	   if search(r'\^\s\{', group):

Would it make sense to check for one or more space characters, \s+? If so,
please add additional tests.


More information about the webkit-reviews mailing list