[webkit-reviews] review granted: [Bug 177853] Add basic support for the version of DataTransferItemList.add that takes a File : [Attachment 322778] Post-review feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 4 22:45:45 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 177853: Add basic support for the version of DataTransferItemList.add that
takes a File
https://bugs.webkit.org/show_bug.cgi?id=177853

Attachment 322778: Post-review feedback

https://bugs.webkit.org/attachment.cgi?id=322778&action=review




--- Comment #22 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 322778
  --> https://bugs.webkit.org/attachment.cgi?id=322778
Post-review feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=322778&action=review

> Source/WebCore/dom/DataTransferItemList.cpp:108
> +    // FIXME: Since file-backed DataTransferItems are not actually written
to the pasteboard yet, we don't need to
> +    // remove any temporary files. When we support writing file-backed
DataTransferItems to the platform pasteboard,
> +    // we will need to clean up here.

Instead of three sentence line FIXME, why don't we just say:
FIXME: Remove the file from the pasteboard object once we added the support for
it.


More information about the webkit-reviews mailing list