[webkit-reviews] review granted: [Bug 177914] Web Inspector: When scrolled Network Table reduces the number of rows it may appear as blank : [Attachment 322777] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 4 21:55:35 PDT 2017


Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 177914: Web Inspector: When scrolled Network Table reduces the number of
rows it may appear as blank
https://bugs.webkit.org/show_bug.cgi?id=177914

Attachment 322777: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=322777&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 322777
  --> https://bugs.webkit.org/attachment.cgi?id=322777
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=322777&action=review

r=me, with (optional) nits.

> Source/WebInspectorUI/UserInterface/Views/Table.js:897
> +	   if (this._cachedScrollTop) {

Might as well use scrollTop from above, since scrollableOffsetHeight is used.

> Source/WebInspectorUI/UserInterface/Views/Table.js:901
> +		   if (this._cachedScrollTop > maximumScrollTop) {

Ditto.

> Source/WebInspectorUI/UserInterface/Views/Table.js:950
> +	   // of rows can fit on screen. Reset the scroll top.

Should this say "Reset the scroll top to zero", so that it's obvious that we
didn't mean to set it to NaN?


More information about the webkit-reviews mailing list