[webkit-reviews] review granted: [Bug 177703] [JSC] Introduce import.meta : [Attachment 322287] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 4 20:15:29 PDT 2017


Filip Pizlo <fpizlo at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 177703: [JSC] Introduce import.meta
https://bugs.webkit.org/show_bug.cgi?id=177703

Attachment 322287: Patch

https://bugs.webkit.org/attachment.cgi?id=322287&action=review




--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 322287
  --> https://bugs.webkit.org/attachment.cgi?id=322287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322287&action=review

> Source/JavaScriptCore/parser/Parser.cpp:431
> +	       // They are `import("...")` call or `import.meta` meta property
cases.

It’s still “this is”. This is one thing, which we choose from two things.
Therefore, singular.


More information about the webkit-reviews mailing list