[webkit-reviews] review granted: [Bug 177796] Break out new touch debugging code into seperate file : [Attachment 322548] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 4 15:32:39 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 177796: Break out new touch debugging code into seperate file
https://bugs.webkit.org/show_bug.cgi?id=177796

Attachment 322548: Patch

https://bugs.webkit.org/attachment.cgi?id=322548&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 322548
  --> https://bugs.webkit.org/attachment.cgi?id=322548
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322548&action=review

> Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:34
> +static const NSUInteger debugTouchDotRadius = 5;
> +static const NSUInteger debugTouchDotSize = debugTouchDotRadius * 2;

These should be CGFloats

> Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:98
> +	   self.debugTouchViews = [NSArray arrayWithArray:debugViews];

Dunno if it's worth the copy just to make it non-mutable.


More information about the webkit-reviews mailing list