[webkit-reviews] review denied: [Bug 168171] [GTK][WPE] All resource load statistics tests added in r212183 crash in GTK bots, timeout in GTK and WPE bots since r219049 : [Attachment 322637] Fix the build

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 168171: [GTK][WPE] All resource load statistics tests added in r212183
crash in GTK bots, timeout in GTK and WPE bots since r219049
https://bugs.webkit.org/show_bug.cgi?id=168171

Attachment 322637: Fix the build

https://bugs.webkit.org/attachment.cgi?id=322637&action=review




--- Comment #24 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 322637
  --> https://bugs.webkit.org/attachment.cgi?id=322637
Fix the build

View in context: https://bugs.webkit.org/attachment.cgi?id=322637&action=review

Please apply previous review comments.

> Source/WebKit/UIProcess/API/APIWebsiteDataStore.h:51
> +    void setStatisticsLastSeen(const String&, double);

We do not need all those methods.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:61
> +   
WebKit::toImpl(dataStoreRef)->setStatisticsLastSeen(WebKit::toImpl(host)->strin
g(), seconds);

auto& statistics = WebKit::toImpl(dataStoreRef)->resourceLoadStatistics();
statistics.setStatisticsLastSeen(WebKit::toImpl(host)->string(), seconds);