[webkit-reviews] review granted: [Bug 177779] [Curl] Reimplement CurlDownload with CurlRequest : [Attachment 322570] fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 19:44:06 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 177779: [Curl] Reimplement CurlDownload with CurlRequest
https://bugs.webkit.org/show_bug.cgi?id=177779

Attachment 322570: fix

https://bugs.webkit.org/attachment.cgi?id=322570&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 322570
  --> https://bugs.webkit.org/attachment.cgi?id=322570
fix

View in context: https://bugs.webkit.org/attachment.cgi?id=322570&action=review

> Source/WebCore/platform/network/curl/CurlDownload.h:69
> +    Ref<CurlRequest> createCurlRequest(ResourceRequest&);

You might want to take a const ResourceRequest& if you're going to copy it or a
ResourceRequest&& if you don't need to copy it.

> Source/WebCore/platform/network/curl/CurlRequest.cpp:616
> +	   m_downloadFilePath = openTemporaryFile("download",
m_downloadFileHandle);

You might want to check if opening failed and not try to re-open it every time
if it fails.


More information about the webkit-reviews mailing list