[webkit-reviews] review granted: [Bug 177839] bmalloc mutex should be adaptive : [Attachment 322615] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 17:50:20 PDT 2017


Michael Saboff <msaboff at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 177839: bmalloc mutex should be adaptive
https://bugs.webkit.org/show_bug.cgi?id=177839

Attachment 322615: the patch

https://bugs.webkit.org/attachment.cgi?id=322615&action=review




--- Comment #5 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 322615
  --> https://bugs.webkit.org/attachment.cgi?id=322615
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322615&action=review

r=me

> Source/WTF/wtf/LockAlgorithmInlines.h:36
> +// NOTE: It's a bug to us any memory order other than seq_cst in this code.
The cost of seq_cst fencing

*use*

> Source/WTF/wtf/WordLock.cpp:79
> +// NOTE: It's a bug to us any memory order other than seq_cst in this code.
The cost of seq_cst fencing

*use*

> Source/bmalloc/bmalloc/StaticMutex.cpp:69
> +// NOTE: It's a bug to us any memory order other than seq_cst in this code.
The cost of seq_cst fencing

*use*


More information about the webkit-reviews mailing list