[webkit-reviews] review granted: [Bug 158938] Web Inspector: preview content view for MIME type application/json should be a collapsible tree outline : [Attachment 322599] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 3 16:14:13 PDT 2017
Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 158938: Web Inspector: preview content view for MIME type application/json
should be a collapsible tree outline
https://bugs.webkit.org/show_bug.cgi?id=158938
Attachment 322599: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=322599&action=review
--- Comment #10 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 322599
--> https://bugs.webkit.org/attachment.cgi?id=322599
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=322599&action=review
r=me, with minor nits.
> Source/WebInspectorUI/ChangeLog:23
> + JSON view evaluates the json content on the page and shows an
ObjectTree
Nit: json -> JSON
> Source/WebInspectorUI/ChangeLog:42
> + In this case the only one we have is a JSON response can get a JSON
view.
Nit: the second sentence is somewhat awkward.
> Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:131
> + get customResponseContentView()
This getter could be simplified a little:
get customResponseContentView()
{
if (!this._canShowCustomResponseContentView())
return null;
if (!this._customResponseContentView)
this._customResponseContentView = new
this._customResponseContentViewConstructor(this._resource);
return this._customResponseContentView;
}
More information about the webkit-reviews
mailing list