[webkit-reviews] review granted: [Bug 177289] Add long press and drag test : [Attachment 322485] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 14:53:42 PDT 2017


Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 177289: Add long press and drag test
https://bugs.webkit.org/show_bug.cgi?id=177289

Attachment 322485: Patch

https://bugs.webkit.org/attachment.cgi?id=322485&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 322485
  --> https://bugs.webkit.org/attachment.cgi?id=322485
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322485&action=review

> LayoutTests/fast/events/touch/ios/long-press-then-drag-to-select-text.html:24
> +	       var dragY = secondTargetRect.y+secondTargetRect.height / 2;

Spaces around binary operators! (i.e. the +s)

> LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:11
> +function longPressAtPointNoLift(X, Y)

I liked pressAndHoldAtPoint better than longPressAtPointNoLift :P

> LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:118
> +		  {

I think the formatting turned a bit Xcode-y here...can we make this consistent
with the function above?


More information about the webkit-reviews mailing list