[webkit-reviews] review granted: [Bug 177751] webkitpy.tool.steps.steps_unittest.StepsTest.test_runtests_api is flakey : [Attachment 322578] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 14:33:06 PDT 2017


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 177751: webkitpy.tool.steps.steps_unittest.StepsTest.test_runtests_api is
flakey
https://bugs.webkit.org/show_bug.cgi?id=177751

Attachment 322578: Patch

https://bugs.webkit.org/attachment.cgi?id=322578&action=review




--- Comment #9 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 322578
  --> https://bugs.webkit.org/attachment.cgi?id=322578
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322578&action=review

> Tools/Scripts/webkitpy/tool/steps/steps_unittest.py:40
> +def output_capture_logs_end_with(testcase, function, args=[], kwargs={},
expected_logs=None):

This method name can be improved. Should have assert in the name.

Also can we add a comment here describing why we need this?

> Tools/Scripts/webkitpy/tool/steps/steps_unittest.py:46
> +	   (_, _, logs_string) = capture.restore_output()

It might be a good idea to also save stdout_string, stderr_string and assert
them to be empty.


More information about the webkit-reviews mailing list