[webkit-reviews] review granted: [Bug 177825] Add ObjC SPI equivalent to WKPageLoaderClient.willGoToBackForwardListItem : [Attachment 322551] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 11:28:04 PDT 2017


Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 177825: Add ObjC SPI equivalent to
WKPageLoaderClient.willGoToBackForwardListItem
https://bugs.webkit.org/show_bug.cgi?id=177825

Attachment 322551: Patch

https://bugs.webkit.org/attachment.cgi?id=322551&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 322551
  --> https://bugs.webkit.org/attachment.cgi?id=322551
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322551&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:1213
> +	   if (m_navigationClient->canHandleWillGoToBackForwardListItem())
> +	       m_navigationClient->willGoToBackForwardListItem(*this, *item,
inPageCache, m_process->transformHandlesToObjects(userData.object()).get());

In both of these patches: didn't we previously use a bool return value to
specify whether it was handled, instead of an extra function? I don't care
either way, but it would be good to be consistent unless you have reason not
to.


More information about the webkit-reviews mailing list