[webkit-reviews] review granted: [Bug 177449] REGRESSION(r222392): [WPE][GTK] Many forms tests are failing due to broken event timestamps : [Attachment 322534] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 10:03:55 PDT 2017


Chris Dumez <cdumez at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 177449: REGRESSION(r222392): [WPE][GTK] Many forms tests are failing due to
broken event timestamps
https://bugs.webkit.org/show_bug.cgi?id=177449

Attachment 322534: Patch

https://bugs.webkit.org/attachment.cgi?id=322534&action=review




--- Comment #40 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 322534
  --> https://bugs.webkit.org/attachment.cgi?id=322534
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322534&action=review

> Source/WebCore/platform/gtk/GtkUtilities.cpp:64
> +    auto time = gdk_event_get_time(event) / 1000.;

I think this would read better as:

auto gdkEventTime = gdk_event_get_time(event);
if (gdkEventTime == GDK_CURRENT_TIME)
    return WallTime::now();
return MonotonicTime::fromRawSeconds(gdkEventTime).approximateWallTime();

but it is your call.

> Source/WebCore/platform/gtk/GtkUtilities.h:37
> +    return time ? MonotonicTime::fromRawSeconds(time).approximateWallTime()
: WallTime::now();

ditto.

> Source/WebKit/Shared/wpe/WebEventFactory.cpp:83
> +    return seconds ?
MonotonicTime::fromRawSeconds(seconds).approximateWallTime() : WallTime::now();

ditto.


More information about the webkit-reviews mailing list