[webkit-reviews] review granted: [Bug 177810] [GLib] Let WebCore know of low power situations : [Attachment 322520] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 09:03:01 PDT 2017


Carlos Garcia Campos <cgarcia at igalia.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 177810: [GLib] Let WebCore know of low power situations
https://bugs.webkit.org/show_bug.cgi?id=177810

Attachment 322520: Patch

https://bugs.webkit.org/attachment.cgi?id=322520&action=review




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 322520
  --> https://bugs.webkit.org/attachment.cgi?id=322520
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322520&action=review

> Source/WebCore/platform/LowPowerModeNotifier.h:66
> +    bool m_lowPowerModeEnabled = false;

bool m_lowPowerModeEnabled { false };

> Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp:48
> +LowPowerModeNotifier::~LowPowerModeNotifier() = default;

Now that I think of it, maybe we cant to disconnect the signal here.


More information about the webkit-reviews mailing list