[webkit-reviews] review granted: [Bug 177817] Allow assigning WeakPtr<Derived> to WeakPtr<Base> : [Attachment 322525] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 08:38:20 PDT 2017


Geoffrey Garen <ggaren at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 177817: Allow assigning WeakPtr<Derived> to WeakPtr<Base>
https://bugs.webkit.org/show_bug.cgi?id=177817

Attachment 322525: patch

https://bugs.webkit.org/attachment.cgi?id=322525&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 322525
  --> https://bugs.webkit.org/attachment.cgi?id=322525
patch

r=me

Now that it's in five places, I think it's time to make a helper function that
does the static_assert and reinterpret_cast on WeakReference<T>. Maybe call it
static_weak_pointer_cast.


More information about the webkit-reviews mailing list