[webkit-reviews] review granted: [Bug 113124] Add animation support for WebP images : [Attachment 322501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 07:44:53 PDT 2017


Zan Dobersek <zan at falconsigh.net> has granted Miguel Gomez
<magomez at igalia.com>'s request for review:
Bug 113124: Add animation support for WebP images
https://bugs.webkit.org/show_bug.cgi?id=113124

Attachment 322501: Patch

https://bugs.webkit.org/attachment.cgi?id=322501&action=review




--- Comment #15 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 322501
  --> https://bugs.webkit.org/attachment.cgi?id=322501
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322501&action=review

> Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp:268
> +    int decodedWidth;
> +    int decodedHeight;

Nit: initialize these to 0;

> Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp:284
> +	       RGBA32* address = buffer.backingStore()->pixelAt(canvasX,
canvasY);

Does this backing store use something like tiles internally? Or is it just a
single chunk of memory? I.e., can we iterate over the RGBA32 values in a single
loop?

> Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h:64
>      void applyColorProfile(const uint8_t*, size_t, ImageFrame&) { };

Can this function be dropped? I think it can be.


More information about the webkit-reviews mailing list