[webkit-reviews] review granted: [Bug 177756] Remove no longer needed WebRTC build infrastructure : [Attachment 322437] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 02:56:47 PDT 2017


Alejandro G. Castro <alex at igalia.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 177756: Remove no longer needed WebRTC build infrastructure
https://bugs.webkit.org/show_bug.cgi?id=177756

Attachment 322437: Patch

https://bugs.webkit.org/attachment.cgi?id=322437&action=review




--- Comment #3 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 322437
  --> https://bugs.webkit.org/attachment.cgi?id=322437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322437&action=review

LGTM, with the small comment.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29229
> +				41B28AEA1F828F6B00FB52AC /*
LibWebRTCProviderCocoa.h in Headers */,

Is this part of the patch?

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:33316
> +				41B28AE91F828F6800FB52AC /*
LibWebRTCProviderCocoa.cpp in Sources */,

Ditto.


More information about the webkit-reviews mailing list