[webkit-reviews] review granted: [Bug 177780] VMTraps shouldn't crash if it sees an exception it doesn't understand. : [Attachment 322444] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 177780: VMTraps shouldn't crash if it sees an exception it doesn't
understand.
https://bugs.webkit.org/show_bug.cgi?id=177780

Attachment 322444: Patch

https://bugs.webkit.org/attachment.cgi?id=322444&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 322444
  --> https://bugs.webkit.org/attachment.cgi?id=322444
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322444&action=review

r=me with fixes.  Would you happen to have a test for this already?

> Source/JavaScriptCore/ChangeLog:11
> +	   noting that this means there's no way to know if, due a bug, we

due *to* a bug.

> Source/JavaScriptCore/runtime/VMTraps.cpp:216
> +		       return SignalAction::HotHandled;

/HotHandled/NotHandled/.