[webkit-reviews] review granted: [Bug 177773] NULL WeakPtr should not malloc! : [Attachment 322429] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 2 14:17:17 PDT 2017


Antti Koivisto <koivisto at iki.fi> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 177773: NULL WeakPtr should not malloc!
https://bugs.webkit.org/show_bug.cgi?id=177773

Attachment 322429: Patch

https://bugs.webkit.org/attachment.cgi?id=322429&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 322429
  --> https://bugs.webkit.org/attachment.cgi?id=322429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322429&action=review

lol yes r=me

> Source/WTF/wtf/WeakPtr.h:70
> +    WeakPtr() { }
> +    WeakPtr(std::nullptr_t) { }
> +    WeakPtr(const WeakPtr& o) : m_ref(o.m_ref) { }

Should also add WeakPtr(WeakPtr&&) = default at some point (and operator= too).


More information about the webkit-reviews mailing list