[webkit-reviews] review granted: [Bug 177778] PasteImage tests are failing on debug builds : [Attachment 322433] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 2 14:08:17 PDT 2017


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 177778: PasteImage tests are failing on debug builds
https://bugs.webkit.org/show_bug.cgi?id=177778

Attachment 322433: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=322433&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 322433
  --> https://bugs.webkit.org/attachment.cgi?id=322433
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=322433&action=review

> Source/WebCore/ChangeLog:8
> +	   After r222702, we're not supposed to be adding "Files" as types.
Removed the code to do this

I think it'd be more accurate to say "...PlatformPasteboard is no longer
responsible for adding "Files" as a type..." here, since "Files" is still added
as a type, it's just that DataTransfer takes care of it now.

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:1036
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110300

I think we'll also need to define out a couple of static helpers above that
will no longer be used on iOS 11.0, otherwise the build will complain about
unused code. I can take care of this in a separate change (as test gardening).


More information about the webkit-reviews mailing list