[webkit-reviews] review granted: [Bug 177769] Implement quality-of-service tiers in WebCoreDecompressionSession : [Attachment 322418] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 2 13:29:56 PDT 2017


Dean Jackson <dino at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 177769: Implement quality-of-service tiers in WebCoreDecompressionSession
https://bugs.webkit.org/show_bug.cgi?id=177769

Attachment 322418: Patch

https://bugs.webkit.org/attachment.cgi?id=322418&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 322418
  --> https://bugs.webkit.org/attachment.cgi?id=322418
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322418&action=review

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:269
> +	   LOG(Media, "WebCoreDecompressionSession::decodeSample(%p) - decoding
took %g%% of duration (%gs vs. %gs)", this, 100. * deltaRatio, delta,
duration);

Won't this produce a LOT of log spew? Maybe do it every N frames as an average?


More information about the webkit-reviews mailing list