[webkit-reviews] review granted: [Bug 177738] [SOUP] Default kerberos authentication credentials are used in ephemeral (private) mode : [Attachment 322364] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 2 04:55:57 PDT 2017


Carlos Garcia Campos <cgarcia at igalia.com> has granted Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 177738: [SOUP] Default kerberos authentication credentials are used in
ephemeral (private) mode
https://bugs.webkit.org/show_bug.cgi?id=177738

Attachment 322364: Patch

https://bugs.webkit.org/attachment.cgi?id=322364&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 322364
  --> https://bugs.webkit.org/attachment.cgi?id=322364
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322364&action=review

> Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:86
> +    globalSessionMap().add(sessionID,
std::make_unique<NetworkStorageSession>(sessionID,
std::make_unique<SoupNetworkSession>(nullptr, sessionID)));

I think we could change the order of the construct parameters t avoid this
nullptr, since when providing cookies we always provide a session id too.

> Source/WebCore/platform/network/soup/SoupNetworkSession.h:51
> -    explicit SoupNetworkSession(SoupCookieJar* = nullptr);
> +    explicit SoupNetworkSession(SoupCookieJar* = nullptr, PAL::SessionID =
PAL::SessionID::emptySessionID());

why is empty session the default and not default session ID? what's the
difference? I guess i doesn't mater as long as is ephemeral is false in both
cases.


More information about the webkit-reviews mailing list