[webkit-reviews] review granted: [Bug 177002] Use vector map routine in WebCore CacheStorage implementation : [Attachment 320911] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 1 20:10:12 PDT 2017


Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 177002: Use vector map routine in WebCore CacheStorage implementation
https://bugs.webkit.org/show_bug.cgi?id=177002

Attachment 320911: Patch

https://bugs.webkit.org/attachment.cgi?id=320911&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 320911
  --> https://bugs.webkit.org/attachment.cgi?id=320911
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320911&action=review

> Source/WebCore/Modules/cache/CacheStorage.cpp:77
> +static inline Ref<DOMCache> copyCache(const Ref<DOMCache>& cache)

This is annoying; just because Ref doesn’t like to be copied without an
explicit call, eh?

> Source/WebCore/Modules/cache/CacheStorage.cpp:130
> +    auto position = m_caches.findMatching([&] (const auto& cache) { return
info.identifier == cache->identifier(); });

Seems like we have the wrong data structure here if we have to loop over all of
these.


More information about the webkit-reviews mailing list