[webkit-reviews] review requested: [Bug 177012] Web Inspector: Styles Redesign: support editing of rule selectors : [Attachment 322334] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 1 14:41:50 PDT 2017


Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 177012: Web Inspector: Styles Redesign: support editing of rule selectors
https://bugs.webkit.org/show_bug.cgi?id=177012

Attachment 322334: Patch

https://bugs.webkit.org/attachment.cgi?id=322334&action=review




--- Comment #10 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 322334

  --> https://bugs.webkit.org/attachment.cgi?id=322334&action=review

Patch

(In reply to Matt Baker from comment #6)
> Other than a couple comments, I think two things need to be address before
> landing, so r- for now:
> - After editing stops, there shouldn’t be a visible focus ring left around
> the selector element.

I'll address it right after this patch in Bug 177711 - Web Inspector: Styles
Redesign: Add support for keyboard navigation (Tab, Shift-Tab, Enter, Esc.

> - A rule selector that doesn’t match anything after being edited will
> disappear. This is unexpected, and there is no way to find the rule again.
> Instead, the selector should become grayed out.

- I'll address it in Bug 177471 - Web Inspector: Styles Redesign: Selector
editing quality improvements, after I address fundamental UI components such as
autocomplete and ability to add new CSS properties.


More information about the webkit-reviews mailing list