[webkit-reviews] review granted: [Bug 177689] Remove ENABLE_CSS_REGIONS : [Attachment 322318] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 177689: Remove ENABLE_CSS_REGIONS
https://bugs.webkit.org/show_bug.cgi?id=177689

Attachment 322318: Patch

https://bugs.webkit.org/attachment.cgi?id=322318&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 322318
  --> https://bugs.webkit.org/attachment.cgi?id=322318
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322318&action=review

>
Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:325
> +    g_warning("%s: CSS Regions support has been removed, this function does
nothing.", __func__);

This says "does nothing".

> Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:249
> +	   g_warning("%s: CSS Regions support has been removed, the
webkit-region-overset property no longer works.", __func__);

This says "no longer works". I think I like "does nothing" better.