[webkit-reviews] review granted: [Bug 180235] REGRESSION (r224791): cookies are shared between ephemeral sessions in the same process pool : [Attachment 328069] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 180235: REGRESSION (r224791): cookies are shared between ephemeral sessions
in the same process pool
https://bugs.webkit.org/show_bug.cgi?id=180235

Attachment 328069: Patch

https://bugs.webkit.org/attachment.cgi?id=328069&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 328069
  --> https://bugs.webkit.org/attachment.cgi?id=328069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328069&action=review

r=me, great test!

> Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:2
> + * Copyright (C) 2016 Apple Inc. All rights reserved.

2017 probably

> Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:33
> +#import <pal/spi/cf/CFNetworkSPI.h>

Is this one needed? What SPI is used below?