[webkit-reviews] review granted: [Bug 180221] Fix some NSOperationQueue leaks : [Attachment 328042] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 180221: Fix some NSOperationQueue leaks
https://bugs.webkit.org/show_bug.cgi?id=180221

Attachment 328042: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=328042&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 328042
  --> https://bugs.webkit.org/attachment.cgi?id=328042
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=328042&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3726
> +	       RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue
new]);

Nit - auto here?

> Source/WebKitLegacy/mac/WebView/WebView.mm:6732
> +	       RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue
new]);

Ditto.