[webkit-reviews] review granted: [Bug 180169] Let's scramble MacroAssemblerCodePtr values. : [Attachment 327992] proposed patch.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 180169: Let's scramble MacroAssemblerCodePtr values.
https://bugs.webkit.org/show_bug.cgi?id=180169

Attachment 327992: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=327992&action=review




--- Comment #13 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 327992
  --> https://bugs.webkit.org/attachment.cgi?id=327992
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=327992&action=review

Nice.

> Source/JavaScriptCore/assembler/CodeLocation.h:167
> -    return CodeLocationInstruction(reinterpret_cast<char*>(dataLocation()) +
offset);
> +    return CodeLocationInstruction(dataLocation<char*>() + offset);

This is a really great change.