[webkit-reviews] review granted: [Bug 180203] Make WorkerThread lifetime much more predictable : [Attachment 327994] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 30 10:59:51 PST 2017
Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 180203: Make WorkerThread lifetime much more predictable
https://bugs.webkit.org/show_bug.cgi?id=180203
Attachment 327994: Patch
https://bugs.webkit.org/attachment.cgi?id=327994&action=review
--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 327994
--> https://bugs.webkit.org/attachment.cgi?id=327994
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=327994&action=review
r=me with a comment.
> Source/WebCore/workers/WorkerThread.cpp:237
> + RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis)] { });
Should probably be a callOnMainThread() since we're in WebCore (and this code
is likely used by iOS WK1)?
More information about the webkit-reviews
mailing list