[webkit-reviews] review granted: [Bug 180178] Missing layer content when animating elements on-screen : [Attachment 327935] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 29 17:41:14 PST 2017
Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 180178: Missing layer content when animating elements on-screen
https://bugs.webkit.org/show_bug.cgi?id=180178
Attachment 327935: Patch
https://bugs.webkit.org/attachment.cgi?id=327935&action=review
--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 327935
--> https://bugs.webkit.org/attachment.cgi?id=327935
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=327935&action=review
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1516
> + bool nowRunningTransformAnimation = wasRunningTransformAnimation;
> + if (m_uncommittedChanges & AnimationChanged)
> + nowRunningTransformAnimation = isRunningTransformAnimation();
> +
> + if (wasRunningTransformAnimation != nowRunningTransformAnimation)
> + childCommitState.ancestorStartedOrEndedTransformAnimation = true;
I wish all this could be one statement, but I can't think of a better way.
More information about the webkit-reviews
mailing list