[webkit-reviews] review granted: [Bug 179587] Web Inspector: Styles Redesign: can't add new property after property without trailing semicolon : [Attachment 327901] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 29 14:19:18 PST 2017
Timothy Hatcher <timothy at hatcher.name> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 179587: Web Inspector: Styles Redesign: can't add new property after
property without trailing semicolon
https://bugs.webkit.org/show_bug.cgi?id=179587
Attachment 327901: Patch
https://bugs.webkit.org/attachment.cgi?id=327901&action=review
--- Comment #11 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 327901
--> https://bugs.webkit.org/attachment.cgi?id=327901
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=327901&action=review
> Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:379
> + return styleText + "; ";
In this case I think return styleText.trimRight() + "; "; would be better then.
And it only trims if needed.
More information about the webkit-reviews
mailing list