[webkit-reviews] review granted: [Bug 180052] Add support for FetchEvent.clientId : [Attachment 327885] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted  review:
Bug 180052: Add support for FetchEvent.clientId
https://bugs.webkit.org/show_bug.cgi?id=180052

Attachment 327885: Patch

https://bugs.webkit.org/attachment.cgi?id=327885&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 327885
  --> https://bugs.webkit.org/attachment.cgi?id=327885
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327885&action=review

r=me with comment

> Source/WebCore/ChangeLog:12
> +	   If the fetch is for a subresouce, clientId is used directly.

Typo: subresouce

> Source/WebCore/loader/FetchOptions.h:227
> +template<class Decoder> inline bool FetchOptions::decode(Decoder& decoder,
FetchOptions& options)

Shouldn't this return an std::optional<> instead of using the legacy pattern?