[webkit-reviews] review granted: [Bug 180070] [JSC] Add MacroAssembler::getEffectiveAddress in all platforms : [Attachment 327736] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 29 09:12:22 PST 2017


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 180070: [JSC] Add MacroAssembler::getEffectiveAddress in all platforms
https://bugs.webkit.org/show_bug.cgi?id=180070

Attachment 327736: Patch

https://bugs.webkit.org/attachment.cgi?id=327736&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 327736
  --> https://bugs.webkit.org/attachment.cgi?id=327736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327736&action=review

> Source/JavaScriptCore/yarr/YarrJIT.cpp:361
> +	   notUnicode.append(branchPtr(AboveOrEqual, regUnicodeInputAndTrail,
regUnicodeTemp));

Is it possible to add a test for this?


More information about the webkit-reviews mailing list