[webkit-reviews] review denied: [Bug 180137] Build should fail early is needed Perl modules are not installed : [Attachment 327850] Proposed patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 180137: Build should fail early is needed Perl modules are not installed
https://bugs.webkit.org/show_bug.cgi?id=180137

Attachment 327850: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=327850&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 327850
  --> https://bugs.webkit.org/attachment.cgi?id=327850
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327850&action=review

>> Source/cmake/WebKitCommon.cmake:25
>> +	find_package(PerlModules COMPONENTS version REQUIRED)
> 
> AFAIU, only File::Copy::Recursive is actually required when you are not using
build-webkit and don't run testing scripts

CMake should only check for Perl modules that are required by the CMake build,
yes. The rest probably don't need to be checked, because we can assume that if
you're using build-webkit, you have run install-dependencies. But they could be
checked at the build-webkit level, I suppose....