[webkit-reviews] review denied: [Bug 180083] [EME] Add support of multi keys from different sessions in CDMinstanceClearKey : [Attachment 327753] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 180083: [EME] Add support of multi keys from different sessions in
CDMinstanceClearKey
https://bugs.webkit.org/show_bug.cgi?id=180083

Attachment 327753: Patch

https://bugs.webkit.org/attachment.cgi?id=327753&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 327753
  --> https://bugs.webkit.org/attachment.cgi?id=327753
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327753&action=review

I think in this case we would be duplicating the keys so I'd suggest checking
for the keys to be inside the Vector before adding a new one.

Another issue I see is that a little bit below, the vector is cleared and
probably we don't want to clear the keys that are still associated with a
session. I think this logic is flawed and needs more work.

Maybe Žan can correct me if I am wrong.

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:545
> +	   for (auto& key : keyVector)
> +	       m_keys.append(key);

If you wanted to do this, which I don't think is what I'd really want, you
could use appendVector.