[webkit-reviews] review granted: [Bug 180125] Web Inspector: Move console Preserve Log setting from Setting tab to Console navigation bar : [Attachment 327825] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 180125: Web Inspector: Move console Preserve Log setting from Setting tab
to Console navigation bar
https://bugs.webkit.org/show_bug.cgi?id=180125

Attachment 327825: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=327825&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 327825
  --> https://bugs.webkit.org/attachment.cgi?id=327825
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=327825&action=review

r=me

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:309
>> +localizedStrings["Do not clear the console on new page loads"] = "Do not
clear the console on new page loads";
> 
> I'm not totally happy with this tooltip but it seems fine.

At least it matches the corresponding checkbox in the Network tab.